Re: [PATCH 3/3] mce: acpi/apei: trace: Enable ghes memory error traceevent

[Naveen N. Rao]

On 08/12/2013 06:23 PM, Borislav Petkov wrote:
> On Mon, Aug 12, 2013 at 06:11:49PM +0530, Naveen N. Rao wrote:
> > So, I looked at ghes_edac and it basically seems to boil down to
> > trace_mc_event. But, this only seems to expose the APEI data as a
> > string and doesn't look to really make all the fields available to
> > user-space in a raw manner. Not sure how well this can be utilised
> > by a user-space tool.
>
> Well, your tracepoint dumps the decoded memory error too. So all the
> information we need is already there, without edac. Or am I missing some
> bits?
>
> Thus why I'm saying is that we don't need the additional edac layer.

You're right - my trace point makes all the data provided by apei as-is 
to userspace. However, ghes_edac seems to squash some of this data into 
a string when reporting through mc_event.

Regards,
Naveen

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/