Re: [PATCH] usb: musb: am335x: Do not remove the session binHOST-only mode

[Bin Liu]

Sebastian,

On Tue, Aug 13, 2013 at 2:14 AM, Sebastian Andrzej Siewior
<bigeasy@xxxxxxxxxxxxx> wrote:
> On 08/09/2013 10:30 PM, Sergei Shtylyov wrote:
>> Hello.
>
> Hi Sergei,
>
>>> +    if (musb->port_mode == MUSB_PORT_MODE_HOST) {
>>> +        val = USBMODE_IDDIG_A;
>>> +        val |= USBMODE_ID_MUX_REG;
>>
>>    Why not do the above in one line and save on {} {}? It will look more
>> aesthetically pleasing IMHO.
>
> I'm going to redo this if it is agreed that we want to fix it that way.
I am going to so some tests today for this. I don't object to use the
mode register, but am wondering why we have to play with it for
host-only mode. The ID pin is grounded for host-only mode, which
should cause the same as setting mode register.

>
> Sebastian

-Bin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/