Re: [PATCH 02/10] leds: lp55xx: add common macros for device attributes

[Bryan Wu]

On Thu, Aug 8, 2013 at 12:59 AM, Milo Kim <woogyom.kim@xxxxxxxxx> wrote:
> This patch provides common macros for LP5521 and LP5523 device attributes and
> functions.
>
> (Device attributes)
> LP5521: 'mode', 'load' and 'selftest'
> LP5523: 'mode', 'load', 'leds' and 'selftest'
>
> (Permissions)
> mode: R/W
> load: Write-only
> leds: R/W
> selftest: Read-only
>
> Couple of lines are duplicate, so use these macros for adding device attributes
> in LP5521 and LP5523 drivers.
>

Good, I will merge this.
-Bryan

> Signed-off-by: Milo Kim <milo.kim@xxxxxx>
> ---
>  drivers/leds/leds-lp55xx-common.h |   47 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 47 insertions(+)
>
> diff --git a/drivers/leds/leds-lp55xx-common.h b/drivers/leds/leds-lp55xx-common.h
> index 04c1d4f..cceab48 100644
> --- a/drivers/leds/leds-lp55xx-common.h
> +++ b/drivers/leds/leds-lp55xx-common.h
> @@ -29,6 +29,53 @@ enum lp55xx_engine_mode {
>         LP55XX_ENGINE_RUN,
>  };
>
> +#define LP55XX_DEV_ATTR_RW(name, show, store)  \
> +       DEVICE_ATTR(name, S_IRUGO | S_IWUSR, show, store)
> +#define LP55XX_DEV_ATTR_RO(name, show)         \
> +       DEVICE_ATTR(name, S_IRUGO, show, NULL)
> +#define LP55XX_DEV_ATTR_WO(name, store)                \
> +       DEVICE_ATTR(name, S_IWUSR, NULL, store)
> +
> +#define show_mode(nr)                                                  \
> +static ssize_t show_engine##nr##_mode(struct device *dev,              \
> +                                   struct device_attribute *attr,      \
> +                                   char *buf)                          \
> +{                                                                      \
> +       return show_engine_mode(dev, attr, buf, nr);                    \
> +}
> +
> +#define store_mode(nr)                                                 \
> +static ssize_t store_engine##nr##_mode(struct device *dev,             \
> +                                    struct device_attribute *attr,     \
> +                                    const char *buf, size_t len)       \
> +{                                                                      \
> +       return store_engine_mode(dev, attr, buf, len, nr);              \
> +}
> +
> +#define show_leds(nr)                                                  \
> +static ssize_t show_engine##nr##_leds(struct device *dev,              \
> +                           struct device_attribute *attr,              \
> +                           char *buf)                                  \
> +{                                                                      \
> +       return show_engine_leds(dev, attr, buf, nr);                    \
> +}
> +
> +#define store_leds(nr)                                         \
> +static ssize_t store_engine##nr##_leds(struct device *dev,     \
> +                            struct device_attribute *attr,     \
> +                            const char *buf, size_t len)       \
> +{                                                              \
> +       return store_engine_leds(dev, attr, buf, len, nr);      \
> +}
> +
> +#define store_load(nr)                                                 \
> +static ssize_t store_engine##nr##_load(struct device *dev,             \
> +                                    struct device_attribute *attr,     \
> +                                    const char *buf, size_t len)       \
> +{                                                                      \
> +       return store_engine_load(dev, attr, buf, len, nr);              \
> +}
> +
>  struct lp55xx_led;
>  struct lp55xx_chip;
>
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/