Re: [PATCH] drivers/rtc/rtc-max77686.c: Fix wrong register

[Andrew Morton]

On Wed, 14 Aug 2013 10:21:41 +0900 Sangjung Woo <sangjung.woo@xxxxxxxxxxx> wrote:

> Fix to read the wrong register when checking whether the RTC timer has
> reached or not.
> 
> ...
>
> --- a/drivers/rtc/rtc-max77686.c
> +++ b/drivers/rtc/rtc-max77686.c
> @@ -240,9 +240,9 @@ static int max77686_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm)
>  	}
>  
>  	alrm->pending = 0;
> -	ret = regmap_read(info->max77686->regmap, MAX77686_REG_STATUS1, &val);
> +	ret = regmap_read(info->max77686->regmap, MAX77686_REG_STATUS2, &val);
>  	if (ret < 0) {
> -		dev_err(info->dev, "%s:%d fail to read status1 reg(%d)\n",
> +		dev_err(info->dev, "%s:%d fail to read status2 reg(%d)\n",
>  				__func__, __LINE__, ret);
>  		goto out;
>  	}

The changelog didn't describe the end-user visible effects of the bug,
so I am unable to determine which kernel version(s) need patching. 
Please always include this information.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/