Re: [PATCH 2/2] ipc/mq: Removed unused def_attr local variable andits initialization in do_create

From: Doug Ledford
Date: Thu Aug 15 2013 - 16:06:58 EST


On 08/12/2013 11:09 AM, Sasikantha Babu wrote:
> In the first patch since we removed calling mq_attr_ok to validate
> mqueue attributes default/ceil values, So removing the unused def_attr
>
> Signed-off-by: Sasikantha Babu <sasikanth.v19@xxxxxxxxx>
> ---
> ipc/mqueue.c | 7 -------
> 1 files changed, 0 insertions(+), 7 deletions(-)
>
> diff --git a/ipc/mqueue.c b/ipc/mqueue.c
> index 04ece80..0bcf69c 100644
> --- a/ipc/mqueue.c
> +++ b/ipc/mqueue.c
> @@ -741,13 +741,6 @@ static struct file *do_create(struct ipc_namespace *ipc_ns, struct inode *dir,
> return ERR_PTR(ret);
> /* store for use during create */
> path->dentry->d_fsdata = attr;
> - } else {
> - struct mq_attr def_attr;
> -
> - def_attr.mq_maxmsg = min(ipc_ns->mq_msg_max,
> - ipc_ns->mq_msg_default);
> - def_attr.mq_msgsize = min(ipc_ns->mq_msgsize_max,
> - ipc_ns->mq_msgsize_default);
> }
>
> mode &= ~current_umask();
>

Nak to this patch as well since it depends on the previous patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/