Re: [PATCH] h8300: include: asm: Kbuild: add gpio.h for pass compiling

[Geert Uytterhoeven]

On Mon, Aug 26, 2013 at 12:16 PM, Chen Gang <gang.chen@xxxxxxxxxxx> wrote:
> Need add default "gpio.h" for h8300, or can not pass compiling.
>
> The related error (allmodconfig for h8300):
>
>   arch/h8300/kernel/h8300_ksyms.c:17:22: fatal error: asm/gpio.h: No such file or directory
>    #include <asm/gpio.h>
>                         ^

I this include needed at all? Perhaps it can just be removed?

> Signed-off-by: Chen Gang <gang.chen@xxxxxxxxxxx>
> ---
>  arch/h8300/include/asm/Kbuild |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/h8300/include/asm/Kbuild b/arch/h8300/include/asm/Kbuild
> index 8ada3cf..4c627aa 100644
> --- a/arch/h8300/include/asm/Kbuild
> +++ b/arch/h8300/include/asm/Kbuild
> @@ -1,6 +1,7 @@
>
>  generic-y += clkdev.h
>  generic-y += exec.h
> +generic-y += gpio.h
>  generic-y += linkage.h
>  generic-y += mmu.h
>  generic-y += module.h

The only gpio-related exports in arch/h8300/kernel/h8300_ksyms.c are:

EXPORT_SYMBOL(h8300_reserved_gpio);
EXPORT_SYMBOL(h8300_free_gpio);
EXPORT_SYMBOL(h8300_set_gpio_dir);

and these are definitely not provided by asm-generic/gpio.h.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/