Re: [PATCH] h8300/kernel/setup.c: add "linux/initrd.h" to pass compiling

[Geert Uytterhoeven]

On Mon, Aug 26, 2013 at 1:06 PM, Chen Gang <gang.chen@xxxxxxxxxxx> wrote:
> On 08/26/2013 07:00 PM, Geert Uytterhoeven wrote:
>> On Mon, Aug 26, 2013 at 12:31 PM, Chen Gang <gang.chen@xxxxxxxxxxx> wrote:
>>> --- a/arch/h8300/kernel/setup.c
>>> +++ b/arch/h8300/kernel/setup.c
>>> @@ -47,6 +47,9 @@
>>>  #include <asm/regs267x.h>
>>>  #endif
>>>
>>> +#if defined(CONFIG_BLK_DEV_INITRD)
>>
>> Why have you added the #ifdef?
>>
>
> The related code is below (maybe we need add additional related
> comments in the patch for it ?).
>
> in arch/h8300/kernel/setup.c
>
>  94 void __init setup_arch(char **cmdline_p)
>  95 {
>  96         int bootmap_size;
>  97
>  98         memory_start = (unsigned long) &_ramstart;
>  99
> 100         /* allow for ROMFS on the end of the kernel */
> 101         if (memcmp((void *)memory_start, "-rom1fs-", 8) == 0) {
> 102 #if defined(CONFIG_BLK_DEV_INITRD)
> 103                 initrd_start = memory_start;
> 104                 initrd_end = memory_start += be32_to_cpu(((unsigned long *) (memory_start))[2]);
> 105 #else
> 106                 memory_start += be32_to_cpu(((unsigned long *) memory_start)[2]);
> 107 #endif
> 108         }

Sure, it's used conditionally. But it doesn't harm to always include it.
That means less #ifdefs in the code.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/