Re: [RFC PATCH v2 06/11] pstore: Add decompression support to pstore

[Aruna Balakrishnaiah]

On Friday 23 August 2013 04:34 AM, Seiji Aguchi wrote:
> > -----Original Message-----
> > From: linux-kernel-owner@xxxxxxxxxxxxxxx [mailto:linux-kernel-owner@xxxxxxxxxxxxxxx] On Behalf Of Aruna Balakrishnaiah
> > Sent: Friday, August 16, 2013 9:18 AM
> > To: linuxppc-dev@xxxxxxxxxx; tony.luck@xxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; keescook@xxxxxxxxxxxx
> > Cc: jkenisto@xxxxxxxxxxxxxxxxxx; ananth@xxxxxxxxxx; benh@xxxxxxxxxxxxxxxxxxx; cbouatmailru@xxxxxxxxx;
> > mahesh@xxxxxxxxxxxxxxxxxx; ccross@xxxxxxxxxxx
> > Subject: [RFC PATCH v2 06/11] pstore: Add decompression support to pstore
> >
> > Based on the flag 'compressed' set or not, pstore will decompress the
> > data returning a plain text file. If decompression fails for a particular
> > record it will have the compressed data in the file which can be
> > decompressed with 'openssl' command line tool.
> If the decompression fails and openssl doesn't work, the worst case is that users can't read the entry.
> In that case, pstore is meaningless at all.

If decompression fails and openssl doesn't work. We have python module zlib to 
decompress
the zlib data. zlib.decompress() should do the trick.

> Also, for users who want to get a single panic message, a compression is not needed.
>
> So, I think we still have to support non-compression mode.
> (IMO, pstore can take kdump as a model. Kdump supports both compression and non-compression mode.)
>
> But, if you think my comment is outside this patchset, it's OK.
> We can make it with a separate patch.
>
> Seiji
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@xxxxxxxxxxxxxxxx
> https://lists.ozlabs.org/listinfo/linuxppc-dev

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/