Re: [PATCH] usb: phy: samsung-usb2: Toggle HSIC GPIO from device tree

[Felipe Balbi]

On Tue, Aug 13, 2013 at 02:11:27PM +0530, Tushar Behera wrote:
> On 12 July 2013 12:27, Felipe Balbi <balbi@xxxxxx> wrote:
> > Hi,
> >
> > On Wed, Jul 10, 2013 at 10:42:27AM -0700, Julius Werner wrote:
> >> Hi Felipe,
> >>
> >> This is intended to pull down a reset signal line, not to switch power
> >> to the device. I could implement that with the regulator framework
> >> too, but I think that would just be confusing and harder to understand
> >> without providing any benefit. It's really just a plain old GPIO.
> >
> > alright, in that case how about using drivers/reset/ ?
> >
> 
> IIUC, reset-gpio driver only provides APIs for reset controls (reset,
> assert, deassert). We still need to find out the location from where
> we would be calling the reset function.

that's fair, but at least you reuse a bunch of boilerplate code to claim
the GPIO, set proper direction and value. No need to duplicate that in
your driver.

-- 
balbi

Attachment: signature.asc
Description: Digital signature