Re: [PATCH v3 5/7] ARM: davinci: da8xx: gpio device creation
From: Sekhar Nori
Date: Tue Aug 27 2013 - 16:06:08 EST
On 8/18/2013 10:49 AM, Lad, Prabhakar wrote:
> From: Philip Avinash <avinashphilip@xxxxxx>
>
> Create davinci gpio device and remove references in davinci_soc_info
> structure. Also rearrange header file inclusion in group basis.
>
> Signed-off-by: Philip Avinash <avinashphilip@xxxxxx>
> Signed-off-by: Sekhar Nori <nsekhar@xxxxxx>
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx>
> Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> ---
> arch/arm/mach-davinci/board-da830-evm.c | 28 ++++++++++++++++-----------
> arch/arm/mach-davinci/board-da850-evm.c | 16 ++++++++++-----
> arch/arm/mach-davinci/board-omapl138-hawk.c | 10 ++++++++--
> arch/arm/mach-davinci/da830.c | 21 +++++++++++++++-----
> arch/arm/mach-davinci/da850.c | 27 ++++++++++++++++++--------
> arch/arm/mach-davinci/include/mach/da8xx.h | 22 +++++++++++----------
> 6 files changed, 83 insertions(+), 41 deletions(-)
>
> #define DA850_EVM_PHY_ID "davinci_mdio-0:00"
> #define DA850_LCD_PWR_PIN GPIO_TO_PIN(2, 8)
> @@ -1439,6 +1441,10 @@ static __init void da850_evm_init(void)
> {
> int ret;
>
> + ret = da850_register_gpio();
> + if (ret)
> + pr_warn("da850_evm_init: GPIO init failed: %d\n", ret);
Changed this to use __func__ for function name print to remain
consistent with rest of this function.
> +int __init da830_register_gpio()
This should be da830_register_gpio(void). Please check the patches you
submit for compilation warnings.
> +int __init da850_register_gpio()
Same problem here too.
Here is the updated patch. Now with just the board updates.
Thanks,
Sekhar
---8<---