Re: [PATCH 12/13] tracing/uprobes: Add more fetch functions

[Namhyung Kim]

Hi Masami,

On Tue, 27 Aug 2013 21:03:32 +0900, Masami Hiramatsu wrote:
> (2013/08/27 17:48), Namhyung Kim wrote:
>> From: Namhyung Kim <namhyung.kim@xxxxxxx>
>> 
>> Implement uprobe-specific stack and memory fetch functions and add
>> them to the uprobes_fetch_type_table.  Other fetch fucntions will be
>> shared with kprobes.

[SNIP]
>> +
>> +static unsigned long get_user_stack_nth(struct pt_regs *regs, unsigned int n)
>> +{
>> +	struct vm_area_struct *vma;
>> +	unsigned long addr = GET_USP(regs);
>
> I recommend you to use user_stack_pointer() rather than GET_USP here.
> Since some arch seem not to have correct GET_USP implementation (e.g. arm),
> kernel build will be failed.

Okay, I'll change to the user_stack_pointer().

>
> And at least trace_probe.c part is good for me.
>
> Reviewed-by: Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx>

Thanks for your review!
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/