Re: [PATCH] imx-drm: Fix probe failure

[Fabio Estevam]

On Wed, Aug 28, 2013 at 5:34 PM, Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote:
> On Wed, Aug 28, 2013 at 05:10:16PM -0300, Fabio Estevam wrote:
>> On Wed, Aug 28, 2013 at 3:54 PM, Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote:
>>
>> > Do the open/close callbacks work?
>>
>> The 'open' callback maps to the generic 'drm_open', so we cannot use it.
>
> We could replace this, but...
>
>>
>> Shouldn't we rely on the refcount done by the drm core instead of
>> doing this manually in imx-drm?
>
> ...This could be a better solution.
>
> you mean (struct drm_device)->open_count, right?

Yes, and open_count is already handled by drm_open/drm_release
callbacks, which is something we currently use inside imx-drm-core.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/