Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

From: Christian Ruppert
Date: Fri Aug 30 2013 - 04:19:48 EST


On Thu, Aug 29, 2013 at 10:24:30AM +0200, Linus Walleij wrote:
> On Thu, Aug 29, 2013 at 9:35 AM, Christian Ruppert
> <christian.ruppert@xxxxxxxxxx> wrote:
> > On Wed, Aug 28, 2013 at 08:49:36PM +0200, Linus Walleij wrote:
> >> On Wed, Aug 21, 2013 at 5:57 PM, Christian Ruppert
> >> <christian.ruppert@xxxxxxxxxx> wrote:
> >> > On Wed, Aug 14, 2013 at 06:53:56PM +0200, Linus Walleij wrote:
> >> >>
> >> >> OK, that can also be called a "bank" or "register" but whatever.
> >> >
> >> > As you suggested below I re-read Documentation/pinctrl.txt and it got me
> >> > even more confused:
> >> > Am I right in my understanding that the whole concept of a
> >> > "port/bank/register" or whatever we would like to call it does not exist
> >> > in the pinctrl framework?
> >>
> >> Not that I know :-)
> >>
> >> If what it means is a number of registers from address x thru x+n
> >> words in memory that is called a register range usually, the
> >> Device Tree "regs" property.
> >>
> >> If you're referring to a subset of registers dealing with a batch
> >> of pins or a single pin that can use whatever terminology you
> >> want, I consider it a driver-internal detail. Some GPIO drivers
> >> talk about "ports" when they have e.g. 2 x 32bit registers
> >> handling a total of 64 pins, then that is port 0 and port 1 or
> >> something like this, but it's really up to the driver.
> >
> > Actually, it's a set of pins the muxing of which is controlled by the
> > same register. E.g. Port A is the set of all the pins which are
> > controlled by register field A.
>
> What is wrong with calling that a "pin-set register" or something?

Nothing. Except perhaps that I hope we can confine that concept to the
driver and thus eliminate the need to talk about it altogether ;)

Greetings,
Christian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/