Re: [PATCH RFC v2 14/16] ARM: vexpress: remove custom .init_timehook
From: Russell King - ARM Linux
Date: Fri Aug 30 2013 - 07:39:36 EST
On Fri, Aug 30, 2013 at 11:02:31AM +0100, Jon Medhurst (Tixy) wrote:
> After adding of_clk_init(NULL) to time_init() things boot OK for me with
> this patch. However, do we know that sched_clock is never going to get
> read before time_init() has actually started the clock it reads? Are we
> making things more fragile?
As I've been saying for years, sched_clock gets read for the first time
in sched_init() -> init_idle() which occurs before time_init().
Whether that matters or not is debatable, but the first read should return
zero, and it will return zero after initialization - so I think all we end
up losing is some accounting of the time taken in the early kernel boot.
If we wish to talk about correctness, then arguably it isn't correct.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/