Re: [PATCH 2/3] extcon: Change field type of 'dev' in extcon_devstructure

[Chanwoo Choi]

Hi Greg,

On 09/02/2013 09:38 AM, Greg KH wrote:
> On Mon, Sep 02, 2013 at 09:20:07AM +0900, Chanwoo Choi wrote:
>> -	edev->dev = kzalloc(sizeof(struct device), GFP_KERNEL);
>> -	if (!edev->dev)
>> -		return -ENOMEM;
>> -	edev->dev->parent = dev;
>> -	edev->dev->class = extcon_class;
>> -	edev->dev->release = extcon_dev_release;
>> +	edev->dev.parent = dev;
>> +	edev->dev.class = extcon_class;
>> +	edev->dev.release = extcon_dev_release;
> 
> You didn't change extcon_dev_release() to properly free all of the
> memory you allocated here, otherwise the slab allocator will oops when
> you try to call it...
> 

I'll fix it. Thanks.

Best Regards,
Chanwoo Choi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/