Re: [PATCH v2 1/3] gpio: pcf857x: change to devm_request_threaded_irq

[Kuninori Morimoto]

Hi

> Remove the request_irq and use devm_request_threaded_irq
> also cleanup free_irq. devm_* takes care of that.
> 
> Signed-off-by: George Cherian <george.cherian@xxxxxx>
> ---
>  arch/arm/boot/dts/dra7-evm.dts |  2 +-
>  drivers/gpio/gpio-pcf857x.c    | 28 ++++++++++++++++++++++++----
>  2 files changed, 25 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
> index 8b0738a..39b44bc 100644
> --- a/arch/arm/boot/dts/dra7-evm.dts
> +++ b/arch/arm/boot/dts/dra7-evm.dts
> @@ -65,7 +65,7 @@
>  		n_latch = <0x1408>;
>  		gpio-controller;
>  		#gpio-cells = <2>;
> -		interrupt-parent = <&pcf_20>;
> +		interrupt-parent = <&gpio20>;
>  		interrupts = <14 2>;
>  		interrupt-controller;
>  		#interrupt-cells = <2>;

I'm not sure detail, 
but does above "exchange interrupt-parent" and "using devm_request_threaded_irq()"
have any relationship ?
Separate patch seems nice ?

Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/