Re: [PATCH] checkpatch: Report missing spaces around trigraphs with--strict

[Josh Triplett]

On Mon, Sep 02, 2013 at 04:54:25PM -0700, Joe Perches wrote:
> > would you mind looking at why
> > it gives a false positive for spaces around '*' on my recent patch at
> > 20130901234251.GB25057@leaf">http://mid.gmane.org/20130901234251.GB25057@leaf ?  It appears to
> > mistake the '*' of a pointer for a multiply.
> 
> Looks like checkpatch thinks this should be a multiplication.
> 
> Try this:
> ---
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 9bb056c..e421b5e 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3005,7 +3005,7 @@ sub process {
>  					 $op eq '*' or $op eq '/' or
>  					 $op eq '%')
>  				{
> -					if ($ctx =~ /Wx[^WCE]|[^WCE]xW/) {
> +					if ($ctx =~ /Wx[^WCEB]|[^WCE]xW/) {
>  						if (ERROR("SPACING",
>  							  "need consistent spacing around '$op' $at\n" . $hereptr)) {
>  							$good = rtrim($fix_elements[$n]) . " " . trim($fix_elements[$n + 1]) . " ";
> 
> 

That patch does indeed fix the problem, thanks!

Tested-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/