Re: [PATCH] Documentation: dt: i2c: Add LPS001WP to the TrivialDevices list

[Mark Rutland]

Hi Lee,

Cheers for producing a binding.

On Wed, Sep 04, 2013 at 02:50:55PM +0100, Lee Jones wrote:
> LPS001WP is a Pressure and Temperature sensor.
> 
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/i2c/trivial-devices.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
> index ad6a738..6038807e6 100644
> --- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt
> +++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
> @@ -57,6 +57,7 @@ st-micro,24c256		i2c serial eeprom  (24cxx)
>  stm,m41t00		Serial Access TIMEKEEPER
>  stm,m41t62		Serial real-time clock (RTC) with alarm
>  stm,m41t80		M41T80 - SERIAL ACCESS RTC WITH ALARMS
> +stm,lps001wp		Pressure and Temperature sensor

As I hinted at in the other thread [1], I don't think this can be
documented as a trivial binding -- the driver expects a couple of
regulators which should be described in the binding (or the driver
shouldn't be using them...).

Also, in the other thread the "st," prefix was used [2], while "stm," is
listed at the prefix in the binding. As far as I can see, "st," should
be used, as it's in vendor-prefixes and "stm," is not.

I'm happy to cook up a patch adding deprecation notes and corrected
strings for the existing incorrect "stm," bindings.

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2013-September/196561.html
[2] http://lists.infradead.org/pipermail/linux-arm-kernel/2013-September/196558.html

Thanks,
Mark.

>  taos,tsl2550		Ambient Light Sensor with SMBUS/Two Wire Serial Interface
>  ti,tsc2003		I2C Touch-Screen Controller
>  ti,tmp102		Low Power Digital Temperature Sensor with SMBUS/Two Wire Serial Interface
> -- 
> 1.8.1.2
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/