Re: [PATCH 2/5] new fscache interface to check cache consistency

[Milosz Tanski]

On Wed, Sep 4, 2013 at 2:13 PM, David Howells <dhowells@xxxxxxxxxx> wrote:
> Milosz Tanski <milosz@xxxxxxxxx> wrote:
>
>> Is it as simple as stick a mutex at the top of the
>> __fscache_check_consistency function before we try to find the object?
>
> You can lock a mutex in a function, but where are you actually going to place
> the mutex struct?  And what other code is going to take it?  To do this, you'd
> have to place the mutex struct in fscache_cookie.  The problem is that you
> have to protect the pointer from fscache_cookie to fscache_object - so placing
> the mutex in fscache_object doesn't help.

David,

I meant lock cookie->lock inside of __fscache_check_consistency in the
beginning of the function. I don't see the need to push this into the
netfs code.

- Milosz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/