Re: [PATCH] dma/Kconfig: Make TI_EDMA select TI_PRIV_EDMA

[Matt Porter]

On 09/04/2013 09:32 AM, Josh Boyer wrote:
> The TI_EDMA driver unconditionally calls functions provided by the
> TI_PRIV_EDMA code, but it doesn't force that to be built-in.  If that isn't
> otherwise enabled somewhere, you can get build errors like:
>
> linux-3.12.0-0.rc0.git1.1.fc21.armv7hl/drivers/dma/edma.c:593: undefined reference to `edma_free_slot'
> drivers/built-in.o: In function `edma_terminate_all':
> linux-3.12.0-0.rc0.git1.1.fc21.armv7hl/drivers/dma/edma.c:169: undefined reference to `edma_stop'
> drivers/built-in.o: In function `edma_execute':
> linux-3.12.0-0.rc0.git1.1.fc21.armv7hl/drivers/dma/edma.c:122: undefined reference to `edma_write_slot'
> linux-3.12.0-0.rc0.git1.1.fc21.armv7hl/drivers/dma/edma.c:149: undefined reference to `edma_link'
> linux-3.12.0-0.rc0.git1.1.fc21.armv7hl/drivers/dma/edma.c:152: undefined reference to `edma_start'
>
> Make TI_EDMA select TI_PRIV_EDMA to avoid this.
>
> Signed-off-by: Josh Boyer <jwboyer@xxxxxxxxxxxxxxxxx>
> ---
>   drivers/dma/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index daa4da2..825374b 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -198,6 +198,7 @@ config TI_EDMA
>   	depends on ARCH_DAVINCI || ARCH_OMAP
>   	select DMA_ENGINE
>   	select DMA_VIRTUAL_CHANNELS
> +	select TI_PRIV_EDMA
>   	default n
>   	help
>   	  Enable support for the TI EDMA controller. This DMA

Looks good, thanks for addressing this.

Acked-by: Matt Porter <matt.porter@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/