Re: increased vmap_area_lock contentions on "n_tty: Move buffers into n_tty_data"

From: Andi Kleen
Date: Wed Sep 25 2013 - 23:20:46 EST


Lin Ming <minggr@xxxxxxxxx> writes:
>
> Would you like below patch?

The loop body keeps rather complex state. It could easily
get confused by parallel RCU changes.

So if the list changes in parallel you may suddenly
report very bogus values, as the va_start - prev_end
computation may be bogus.

Perhaps it's ok (may report bogus gaps), but it seems a bit risky.

-Andi

--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/