Re: [PATCH char-misc-next 0/5] misc: mic: driver cleanups and abuild fix.

[Sudeep Dutt]

On Fri, 2013-09-27 at 10:29 -0700, Joe Perches wrote:
> On Fri, 2013-09-27 at 09:49 -0700, Sudeep Dutt wrote:
> > These patches address code review feedback received on the
> > patch series @ https://lkml.org/lkml/2013/9/5/561 ,from:
> > a) Greg Kroah-Hartman on sysfs and header file cleanups.
> > b) Joe Perches on issues found by "--strict" checkpatch.
> > 
> > It should also fix the build failures on certain non X86
> > architectures, reported in linux-next and 0-DAY builds.
> > 
> > Ashutosh Dixit (1):
> >   misc: mic: cleanups for "--strict" checkpatch.
> > 
> > Sudeep Dutt (4):
> >   misc: mic: host driver sysfs cleanups.
> >   misc: mic: header file cleanups.
> >   misc: mic: fix a warning in the IOCTL header file.
> >   misc: mic: depend on X86 for both host and card drivers.
> > 
> >  Documentation/mic/mpssd/mpssd.c                    | 65 +++++++--------
> >  Documentation/mic/mpssd/sysfs.c                    |  4 +-
> 
> Why are these in Documentation/ at all?
> Shouldn't the directory be moved to tools/ ?
> 

Currently, this is just sample working code for configuring MIC devices.
The longer term plan is to move this code to tools/ but not with this
patch series.

> It doesn't build normally btw.
> 
> Also, there are some defects/shortcomings here:
> 

We will post a follow up patch incorporating the changes below next
week. It would be great if this cleanup series is applied to
char-misc-next as is since patch 5 should fix a linux-next build failure
with powerpc.

Thanks for the review!
Sudeep Dutt

>  Documentation/mic/mpssd/mpssd.c | 7 ++++---
>  Documentation/mic/mpssd/mpssd.h | 1 +
>  2 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/mic/mpssd/mpssd.c b/Documentation/mic/mpssd/mpssd.c
> index 8064804..cb62663 100644
> --- a/Documentation/mic/mpssd/mpssd.c
> +++ b/Documentation/mic/mpssd/mpssd.c
> @@ -379,7 +379,7 @@ disp_iovec(struct mic_info *mic, struct mic_copy_desc *copy,
>  	for (i = 0; i < copy->iovcnt; i++)
>  		mpsslog("%s %s %d copy->iov[%d] addr %p len 0x%lx\n",
>  			mic->name, s, line, i,
> -			copy->iov[i].iov_base, copy->iov[i].iov_len);
> +			copy->iov[i].iov_base, (long)copy->iov[i].iov_len);
>  }
>  
>  static inline __u16 read_avail_idx(struct mic_vring *vr)
> @@ -953,7 +953,8 @@ set_backend_file(struct mic_info *mic)
>  		return false;
>  	mic->mic_virtblk.backend_file = malloc(strlen(evv) + 1);
>  	if (mic->mic_virtblk.backend_file == NULL) {
> -		mpsslog("can't allocate memory\n", mic->name, mic->id);
> +		mpsslog("%s id %d - can't allocate memory\n",
> +			mic->name, mic->id);
>  		return false;
>  	}
>  	strcpy(mic->mic_virtblk.backend_file, evv + 1);
> @@ -1026,7 +1027,7 @@ close_backend(struct mic_info *mic)
>  static bool
>  start_virtblk(struct mic_info *mic, struct mic_vring *vring)
>  {
> -	if (((__u64)&virtblk_dev_page.blk_config % 8) != 0) {
> +	if (((__u64)(unsigned long)&virtblk_dev_page.blk_config % 8) != 0) {
>  		mpsslog("%s: blk_config is not 8 byte aligned.\n",
>  			mic->name);
>  		return false;
> diff --git a/Documentation/mic/mpssd/mpssd.h b/Documentation/mic/mpssd/mpssd.h
> index b6dee38..ccd589f 100644
> --- a/Documentation/mic/mpssd/mpssd.h
> +++ b/Documentation/mic/mpssd/mpssd.h
> @@ -94,6 +94,7 @@ struct mic_info {
>  	struct mic_info *next;
>  };
>  
> +__attribute__((format(printf, 1, 2)))
>  void mpsslog(char *format, ...);
>  char *readsysfs(char *dir, char *entry);
>  int setsysfs(char *dir, char *entry, char *value);
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/