Re: [PATCH] x86/geode: fix incorrect placement of __initdata tag

[Bartlomiej Zolnierkiewicz]

Hi,

On Tuesday, October 01, 2013 08:59:50 AM Ingo Molnar wrote:
> 
> * Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx> wrote:
> 
> > __initdata tag should be placed between the variable name and equal
> > sign for the variable to be placed in the intended .init.data section.
> > 
> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>
> > Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> > ---
> >  arch/x86/platform/geode/alix.c    | 2 +-
> >  arch/x86/platform/geode/geos.c    | 2 +-
> >  arch/x86/platform/geode/net5501.c | 2 +-
> >  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> Does this fix have any runtime effects, i.e. should we queue this up as an 
> urgent fix for v3.12, or does tip:x86/platform with a v3.13 merge suffice?

It has runtime effects as the data now goes into .init.data which was not
a case previously. However it is not an urgent fix so I think that queuing
it for v3.13 is a better option. Thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/