Re: [PATCH] USB: gadget: s3c-hsotg: fix maxpacket size

[Felipe Balbi]

Hi,

On Fri, Sep 27, 2013 at 12:31:09PM +0200, Robert Baldyga wrote:
> This patch changes ep maxpacket value from 512 to 1024, becouse it's needed

shouldn't you use 3072 instead to cope with high bandwidth ISO
endpoints ?

> to handle interupt and isochronous endpoints in high-speed mode. This change
> doesn't affect on driver functioning, becouse fifo size (3072) is still enough

s/becouse/because.

> for the maximum transaction payload (3*1024 for high-speed high-bandwidtch
> endpoints).
> 
> Signed-off-by: Robert Baldyga <r.baldyga@xxxxxxxxxxx>
> ---
>  drivers/usb/gadget/s3c-hsotg.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c
> index 8a9e2c6..0d1dcbd 100644
> --- a/drivers/usb/gadget/s3c-hsotg.c
> +++ b/drivers/usb/gadget/s3c-hsotg.c
> @@ -3146,7 +3146,7 @@ static void s3c_hsotg_initep(struct s3c_hsotg *hsotg,
>  
>  	hs_ep->parent = hsotg;
>  	hs_ep->ep.name = hs_ep->name;
> -	hs_ep->ep.maxpacket = epnum ? 512 : EP0_MPS_LIMIT;
> +	hs_ep->ep.maxpacket = epnum ? 1024 : EP0_MPS_LIMIT;
>  	hs_ep->ep.ops = &s3c_hsotg_ep_ops;
>  
>  	/*
> -- 
> 1.7.9.5
> 

-- 
balbi

Attachment: signature.asc
Description: Digital signature