Re: [PATCH] mm: pagevec: cleanup: drop pvec->cold argument in allplaces

[David Rientjes]

On Mon, 30 Sep 2013, Andrew Morton wrote:

> > Nobody uses the pvec->cold argument of pagevec and it's also unreasonable for
> > pages in pagevec released as cold page, so drop the cold argument from pagevec.
> 
> Is it unreasonable?  I'd say it's unreasonable to assume that all pages
> in all cases are likely to be cache-hot.  Example: what if the pages
> are being truncated and were found to be on the inactive LRU,
> unreferenced?
> 
> A useful exercise would be to go through all those pagevec_init() sites
> and convince ourselves that the decision at each place was the correct
> one.
> 

Agreed, and the "cold" argument to release_pages() becomes a no-op if this 
patch is merged meaning that anything released through it will 
automatically go to the start of the pcp lists.  If the pages aren't hot 
then this is exactly the opposite of what we wanted to do; the fact that 
the pvec length doesn't take into account the size of cpu cache can almost 
guarantee that everything isn't cache hot.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/