Re: [PATCH 3/4] regulator: da9052: Use apply_[reg|bit] with regmapbased voltage_sel operations

[Mark Brown]

On Wed, Oct 02, 2013 at 12:15:00PM +0200, Michael Grzeschik wrote:

> we should not play to much with generous functions for this pmics. With this
> patch we loose the fix_io code path from da9052_reg_update.

> I suggest that Mark queue the revert of this patch.

This seems far too obscure to be robust - if we need to bodge all I2C
I/O (which is what that looks like) then that should be being done in
the regmap for the device rather than by having stuff open coded in the
function drivers like this.

Attachment: signature.asc
Description: Digital signature