Re: FW: [PATCH] hidraw: close underlying device at removal of lastreader

From: Jiri Kosina
Date: Wed Oct 02 2013 - 11:02:55 EST


On Tue, 1 Oct 2013, Manoj Chourasia wrote:

> Hi Jiri,
>
> Mika Westerberg mika.westerberg@xxxxxxxxxxxxxxx reported a bug introduced in hid driver after
> commit 212a871a393 (HID: hidraw: correctly deallocate memory on device disconnect)
> that hidraw doesn't close the underlying hid device when the device node is closed last time.
>
> I am proposing following patch as fix.  Please review it.  Mika will help in testing.
>
> ----------------------------------------
> >From b37519b65be0d51b90c5fc177c0dc0cd2f6358b1 Mon Sep 17 00:00:00 2001
> From: Manoj Chourasia <mchourasia@xxxxxxxxxx>
> Date: Tue, 1 Oct 2013 15:39:00 +0530
> Subject: [PATCH] HID: hidraw: close underlying device at removal of last reader
>
> Even though device exist bit is set the underlying
> HW device should be closed when the last reader
> of the device is closed i.e. open count drops to zero.
>
> Signed-off-by: Manoj Chourasia <mchourasia@xxxxxxxxxx>

Applied, thanks a lot to both of you.

--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/