Re: [PATCH V3 net-next] fib_trie: avoid a redundant bit judgementin inflate

From: David Miller
Date: Wed Oct 02 2013 - 16:37:57 EST


From: baker.kernel@xxxxxxxxx
Date: Tue, 1 Oct 2013 07:45:09 +0800

> From: "baker.zhang" <baker.kernel@xxxxxxxxx>
>
> Because 'node' is the i'st child of 'oldnode',
> thus, here 'i' equals
> tkey_extract_bits(node->key, oldtnode->pos, oldtnode->bits)
>
> we just get 1 more bit,
> and need not care the detail value of this bits.
>
> I apologize for the mistake.
>
> I generated the patch on a branch version,
> and did not notice the put_child has been changed.
>
> I have redone the test on HEAD version with my patch.

Applied, thanks for testing things so thoroughly.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/