Re: [PATCH 2/5] ARM: dts: Add dp-controller node to exynos5250-snow

[Sean Paul]

On Wed, Oct 2, 2013 at 5:10 PM, Olof Johansson <olof@xxxxxxxxx> wrote:
> On Tue, Oct 1, 2013 at 4:40 PM, Sean Paul <seanpaul@xxxxxxxxxxxx> wrote:
>> This patch adds the dp-controller node to the exynos5250-snow board dts
>> file.
>>
>> Signed-off-by: Sean Paul <seanpaul@xxxxxxxxxxxx>
>> ---
>>  arch/arm/boot/dts/exynos5250-snow.dts | 12 ++++++++++++
>>  1 file changed, 12 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
>> index e5af3f2..780511a 100644
>> --- a/arch/arm/boot/dts/exynos5250-snow.dts
>> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
>> @@ -190,6 +190,18 @@
>>                 samsung,vbus-gpio = <&gpx1 1 0>;
>>         };
>>
>> +       dp-controller {
>> +               samsung,color-space = <0>;
>> +               samsung,dynamic-range = <0>;
>> +               samsung,ycbcr-coeff = <0>;
>> +               samsung,color-depth = <1>;
>> +               samsung,link-rate = <0x0a>;
>> +               samsung,lane-count = <2>;
>> +
>> +               pinctrl-names = "default";
>> +               pinctrl-0 = <&dp_hpd>;
>> +       };
>
> This won't actually do what I think you want. Since the dtsi has the
> node name "dp-controller@145B0000", you will end up duplicating a new
> node and not build on top of that one.
>

Thanks, Olof. I based this off Inki's exynos-drm-next tree which does
not have the latest from arm-soc, I'll re-upload.

Sean


> There's two ways to do it: Always include the unit address, or create
> a label in the dtsi such that:
>
> dp_controller: dp-controller@ {....
> }
>
> Then in your dts you can, at the root level:
>
> &dp_controller {
>   ... new stuff and overrides ...
> };
>
>
>
> -Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/