Re: [PATCH] serial: sccnxp: replace memcpy with struct assignment

[Greg Kroah-Hartman]

On Tue, Oct 01, 2013 at 07:31:15PM +0800, Fengguang Wu wrote:
> Generated by: coccinelle/misc/memcpy-assign.cocci
> 
> CC: Alexander Shiyan <shc_work@xxxxxxx>
> Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
> ---
> 
>  drivers/tty/serial/sccnxp.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-next.orig/drivers/tty/serial/sccnxp.c	2013-10-01 19:27:55.057537955 +0800
> +++ linux-next/drivers/tty/serial/sccnxp.c	2013-10-01 19:28:17.873536923 +0800
> @@ -907,7 +907,7 @@ static int sccnxp_probe(struct platform_
>  	}
>  
>  	if (pdata)
> -		memcpy(&s->pdata, pdata, sizeof(struct sccnxp_pdata));
> +		s->pdata = *pdata;

I don't think you compiled this, as it breaks the build :(

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/