Re: [PATCHv4 2/4] ARM: msm: Add support for APQ8074 Dragonboard

[Rohit Vaswani]

On 10/4/2013 1:28 AM, Ivan T. Ivanov wrote:
> Hi Rohit,
>
> On Thu, 2013-10-03 at 16:05 -0700, Rohit Vaswani wrote:
> > This patch adds basic board support for APQ8074 Dragonboard
> > which belongs to the Snapdragon 800 family.
> > For now, just support a basic machine with device tree.
> >
> > Signed-off-by: Rohit Vaswani <rvaswani@xxxxxxxxxxxxxx>
> > ---
> >   arch/arm/boot/dts/Makefile                     |  3 ++-
> >   arch/arm/boot/dts/qcom-apq8074-dragonboard.dts |  6 +++++
> >   arch/arm/boot/dts/qcom-msm8974.dtsi            | 35 ++++++++++++++++++++++++++
> >   arch/arm/mach-msm/Kconfig                      | 13 ++++++++++
> >   arch/arm/mach-msm/board-dt.c                   |  9 +++++++
> >   5 files changed, 65 insertions(+), 1 deletion(-)
> >   create mode 100644 arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
> >   create mode 100644 arch/arm/boot/dts/qcom-msm8974.dtsi
> >
> > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > index 000cf76..e71a3ec 100644
> > --- a/arch/arm/boot/dts/Makefile
> > +++ b/arch/arm/boot/dts/Makefile
> > @@ -102,7 +102,8 @@ dtb-$(CONFIG_ARCH_KIRKWOOD) += kirkwood-cloudbox.dtb \
> >   	kirkwood-openblocks_a6.dtb
> >   dtb-$(CONFIG_ARCH_MARCO) += marco-evb.dtb
> >   dtb-$(CONFIG_ARCH_MSM) += msm8660-surf.dtb \
> > -	msm8960-cdp.dtb
> > +	msm8960-cdp.dtb \
> > +	qcom-apq8074-dragonboard.dtb
> >   dtb-$(CONFIG_ARCH_MVEBU) += armada-370-db.dtb \
> >   	armada-370-mirabox.dtb \
> >   	armada-370-netgear-rn102.dtb \
> > diff --git a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
> > new file mode 100644
> > index 0000000..bb6f3c4
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
> > @@ -0,0 +1,6 @@
> > +/include/ "qcom-msm8974.dtsi"
> Please, could you replace /include/ by #include. This will allow
> us to use of #define features from C header files. Since[1] we have
> clocks indexes definitions shared between C code and DT files.

Will do.
> Thanks,
> Ivan
>
> [1] http://www.spinics.net/lists/arm-kernel/msg276937.html


Thanks,
Rohit Vaswani

--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/