[PATCH] regulator: core: Always warn when using a dummy regulator

From: Mark Brown
Date: Fri Oct 04 2013 - 06:44:36 EST


From: Mark Brown <broonie@xxxxxxxxxx>

This helps people spot if they have missed a supply from a device tree or
equivalent data structure.

Suggested-by: Stephen Warren <swarren@xxxxxxxxxx>
Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>
---
drivers/regulator/core.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 6333080..13263d1 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -1299,13 +1299,8 @@ static struct regulator *_regulator_get(struct device *dev, const char *id,
* even if it isn't hooked up and just provide a dummy.
*/
if (has_full_constraints && allow_dummy) {
- /*
- * Log the substitution if regulator configuration is
- * not complete to help development.
- */
- if (!has_full_constraints)
- pr_warn("%s supply %s not found, using dummy regulator\n",
- devname, id);
+ pr_warn("%s supply %s not found, using dummy regulator\n",
+ devname, id);

rdev = dummy_regulator_rdev;
goto found;
--
1.8.4.rc3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/