Re: [PATCH] ftrace, sched: Add TRACE_FLAG_PREEMPT_RESCHED

[Steven Rostedt]

On Fri, 4 Oct 2013 10:09:09 +0200
Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> On Fri, Sep 27, 2013 at 05:29:08PM +0200, Peter Zijlstra wrote:
> > Subject: ftrace, sched: Add TRACE_FLAG_PREEMPT_RESCHED
> > From: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> > Date: Fri Sep 27 17:11:00 CEST 2013
> > 
> > Since we now have two need_resched states; trace the two so we can
> > observe discrepancies.
> > 
> > Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> > Signed-off-by: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> 
> Steve, if you're done conferencing.. any objections?
> 

Taking a quick look, my only objection so far is that the change log is
rather flimsy. What are the two states and what are their dependencies?

In other words, what does these flags in the trace actually mean?
Probably need to add comments in the code and/or update the
Documentation section

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/