Re: [PATCH 2/3] rcu: Create rcu_sync infrastructure

[Oleg Nesterov]

On 10/04, Peter Zijlstra wrote:
>
> On Fri, Oct 04, 2013 at 03:31:35PM +0200, Oleg Nesterov wrote:
> > > I'm really starting to think we shouldn't do this in rcu_sync at all.
> >
> > I do not really understand why you insist that rcu_sync() should not
> > try to help to the users which need the exclusive mode.
>
> But what other users; you yourself said that percpu-rwsem isn't one for
> long if ever.

Not sure I understand...

percpu-rwsem will use exclusive mode, with or without the possible
improvements we can copy from cpuhp. sb_writers can probably use it
too (along with other helpers from percpu-rwsem we do not have yet).

If you mean that the "raw" rcu_sync infrastructure will never have
more users, will I am not sure, it looks "natural". But I can not
know for sure.

OK, I am not going to argue too much, let me send other patches
you seem to agree with. I am also going to send this one for the
record/review (without __complete_locked), please ack-or-nack it
explicitly.

I am not trying saying this feature is "must have", of course it
is not. The only problem, I am a bit puzzled why you dislike it
that much.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/