Re: [PATCH v2 2/6] PowerCap: Add class driver

[Greg KH]

On Fri, Oct 04, 2013 at 09:36:52AM -0700, Srinivas Pandruvada wrote:
> +/* Power zone ro attributes define */
> +#define powercap_attr_ro(_name)		\
> +	static DEVICE_ATTR(_name, 0444, show_##_name, NULL)
> +
> +/* Power zone rw attributes define */
> +#define powercap_attr_rw(_name)		\
> +	static DEVICE_ATTR(_name, 0644, show_##_name, store_##_name)
> +
> +/* constraint attributes define rw */
> +#define powercap_const_attr_rw(_name)		\
> +	static DEVICE_ATTR(_name, 0644, show_constraint_##_name, \
> +				store_constraint_##_name)
> +/* constraint attributes define ro */
> +#define powercap_const_attr_ro(_name)		\
> +	static DEVICE_ATTR(_name, 0644, show_constraint_##_name, NULL)

Minor nit:

Why are you using your own defines, why not just use the
DEVICE_ATTR_RO() and DEVICE_ATTR_RW() macros?  That way it makes it
easier to grep for attributes, and ensure they have set the mode bits
properly.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/