Re: [PATCH] Remove redundant and incorrect memset()

[H. Peter Anvin]

On 10/04/2013 10:33 AM, Ingo Molnar wrote:
> 
> * Roy Franz <roy.franz@xxxxxxxxxx> wrote:
> 
>> Remove a redundant memset() call from efi_relocate_kernel() that
>> was clearing memory that would be used by BSS in non-compressed
>> images loaded with this function.  This clear was redundant with
>> the clearing done in the image itself, and also implemented incorrectly
>> with a 0 length.
>>
>> Signed-off-by: Roy Franz <roy.franz@xxxxxxxxxx>
>> Acked-by: Mark Salter <msalter@xxxxxxxxxx>
> 
> Note the title:
> 
>    [PATCH] Remove redundant and incorrect memset()
> 
> if it's both redundant *and* incorrect then the other memset() must be 
> incorrect too and must be removed as well ;-)
> 
> I suspect you wanted the title to say:
> 
>    [PATCH] Remove redundant memset()
> 

And more importantly:

[PATCH] boot,efi: Remove redundant memset()

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/