Re: [PATCH] checkpatch.pl: Check for the FSF mailing address

From: Josh Triplett
Date: Sun Oct 06 2013 - 17:19:09 EST


On Sat, Oct 05, 2013 at 11:27:39PM -0700, Greg Kroah-Hartman wrote:
> On Sat, Oct 05, 2013 at 11:51:48AM -0700, Joe Perches wrote:
> > On Sat, 2013-10-05 at 11:43 -0700, Josh Triplett wrote:
> > > Kernel maintainers reject new instances of the GPL boilerplate paragraph
> > > directing people to write to the FSF for a copy of the GPL, since the
> > > FSF has moved in the past and may do so again.
> > []
> > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > []
> > > @@ -1859,6 +1859,16 @@ sub process {
> > > $rpt_cleaners = 1;
> > > }
> > >
> > > +# Check for FSF mailing addresses.
> > > + if ($rawline =~ /You should have received a copy/ ||
> >
> > There are over 9,000 of these in the tree.
> >
> > > + $rawline =~ /write to the Free Software/ ||
> >
> > Over 7,000
> >
> > > + $rawline =~ /59 Temple Place/ ||
> >
> > Over 3,500
> >
> > > + $rawline =~ /51 Franklin Street/) {
> >
> > Over 1,500
>
> Then we should remove them all. I know some FSF members have tried to
> do a sweep of the kernel tree at times to at least get rid of the old
> physical address, but it looks like that didn't work very well.
>
> I don't want to see this get worse over time, Josh, thanks for doing
> this checkpatch patch.
>
> Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

Thanks, Greg!

Given this ack, any objections to merging the patch in its current form?

- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/