Re: [PATCH] acpi: update win8 OSI blacklist

[Felipe Contreras]

On Sun, Oct 6, 2013 at 3:59 PM, Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote:
> On Sun, Oct 06, 2013 at 03:51:05PM -0500, Felipe Contreras wrote:
>> On Sun, Oct 6, 2013 at 3:45 PM, Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote:
>> > On Sun, Oct 06, 2013 at 03:40:42PM -0500, Felipe Contreras wrote:
>> >
>> >> In case you didn't hear, the plan was to add an entry if a user
>> >> reports the backlight not working correctly, and acpi_osi="!Windows
>> >> 2012" fixing it with no negative effects. and that's what users did in
>> >> bug #60682.
>> >
>> > So add that to each entry you're adding to the list.
>>
>> No. These entries are already there, I'm merely updating it. I added a
>> comment before the list, but the comment was removed.
>
> There's no point in having a comment that describes a list, because
> someone will inevitably reorder them or insert things in between at some
> point. Add a comment per entry.

>From acpi_osi_dmi_table:

/*
* BIOS invocation of _OSI(Linux) is almost always a BIOS bug.
* Linux ignores it, except for the machines enumerated below.
*/

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/