Re: [PATCH] checkpatch: Add check for sscanf without return use

From: Joe Perches
Date: Mon Oct 07 2013 - 20:03:23 EST


On Mon, 2013-10-07 at 16:56 -0700, Andrew Morton wrote:
> On Mon, 07 Oct 2013 16:45:23 -0700 Joe Perches <joe@xxxxxxxxxxx> wrote:
>
> > Naked use sscanf can be troublesome.
>
> It would be helpful to expand on "troublesome"?

Dunno, you either know or the couple of paragraphs
it takes to explain with examples won't really be
too helpful in a commit log.

> > Add a warning when the sscanf return value is not used.
> Maybe it should be __must_check?

Maybe.

That might be easier but there'll be a couple
hundred new build warnings.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/