Re: [PATCH 8/8] ACPI / trace: Add trace interface for eMCA driver

[Borislav Petkov]

On Tue, Oct 15, 2013 at 09:43:46PM -0300, Mauro Carvalho Chehab wrote:
> Using a custom typedef here seems problematic, as that can make userspace
> interface more complicated.

It is defined in a userspace header: include/uapi/linux/uuid.h

> > >>> +		char *fru_text,
> > >>> +		u64 error_count,
> > >>> +		u32 severity,
> > >>> +		u64 phy_addr,
> > >>> +		char *mem_loc),
> 
> By looking on the rest of the changes, the mem_loc can now contain the 
> right location of the memory error, including on what DIMM the error
> happened. It can also (optionally) contain the DIMM label.

No, dimm_loc contains the label.

> Also, userspace needs to know what's the granularity for the error
> that an eMCA driver will give, in order to adjust its policies.

u32 error_count

> If you don't create the EDAC nodes, it means that userspace doesn't
> have any glue about what error information will be provided.

Of course it does - it is a tracepoint. There's no need for EDAC at all
with eMCA present on the system.

> In any case, this is provided by the EDAC core functions that describe
> the memory in details. So, IMHO, get rid of EDAC is a big mistake.

No one said we're getting rid of EDAC - we're basically disabling its
services on machines with eMCA because we simply don't need it.

> It is also nice to allow the user to choose his preferred mechanism,
> when more than one is properly supported on a given system.

We did this with firmware-first reporting so I don't see any need
for user interaction. When you have eMCA on the system, you disable
everything else reporting memory errors and go to sleep. So, similar to
firmware first.

If eMCA turns out to have f*cked BIOS implementations - which I don't
doubt - then we can add a chicken bit similar to "acpi=nocmcff"

It is that simple.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/