Re: [PATCH 4/5] uprobes: Change uprobe_copy_process() to dupreturn_instances

From: Srikar Dronamraju
Date: Wed Oct 16 2013 - 08:47:44 EST


* Oleg Nesterov <oleg@xxxxxxxxxx> [2013-10-13 21:18:41]:

> uprobe_copy_process() assumes that the new child doesn't need
> ->utask, it should be allocated by demand.
>
> But this is not true if the forking task has the pending ret-
> probes, the child should report them as well and thus it needs
> the copy of parent's ->return_instances chain. Otherwise the
> child crashes when it returns from the probed function.
>
> Note: this change alone doesn't fix the problem, see the next
> change.
>
> Cc: stable@xxxxxxxxxxxxxxx # 3.9+
> Reported-by: Martin Cermak <mcermak@xxxxxxxxxx>
> Reported-by: David Smith <dsmith@xxxxxxxxxx>
> Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>

Acked-by: Srikar Dronamraju <srikar@xxxxxxxxxxxxxxxxxx>


--
Thanks and Regards
Srikar Dronamraju

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/