Re: [PATCH 3/6] mm: Use raw_cpu ops for determining current NUMAnode

From: Christoph Lameter
Date: Wed Oct 16 2013 - 10:22:28 EST


On Wed, 16 Oct 2013, Peter Zijlstra wrote:


> NAK; smp_processor_id() has the preemption checks; for consistently
> numa_node_id() should have them too, for the very same reason. Who's to
> say the node id is still valid when you return from this function? If
> we're preemptable we could've just been migrated away to another node.
>
> So please introduce raw_numa_node_id() and use that; all fully analogous
> to smp_processor_id().

The code that was here before the use of this_cpu ops did use
raw_smp_processor_id.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/