Re: [PATCH 6/6] percpu: Add preemption checks to __this_cpu ops

[Christoph Lameter]

On Wed, 16 Oct 2013, Peter Zijlstra wrote:

> So I didn't understand what was wrong with:
>
> #define __this_cpu_read(pcp) \
> 	(__this_cpu_preempt_check("read"), raw_this_cpu_read(pcp))
>
> And idem for all others. This is 1) shorter to write; and 2) makes it
> blindingly obvious that the implementations are actually the same.

Nothing wrong with that. It just increases the scope of this patch to
require modifications to arch code and I already have trouble enough
following through on all the issues that were raised so far.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/