Re: [PATCH v2 3/9] bitops: Introduce a more generic BITMASK macro

[Chen Gong]

On Wed, Oct 16, 2013 at 02:02:21PM -0300, Mauro Carvalho Chehab wrote:
> Date: Wed, 16 Oct 2013 14:02:21 -0300
> From: Mauro Carvalho Chehab <m.chehab@xxxxxxxxxxx>
> To: "Chen, Gong" <gong.chen@xxxxxxxxxxxxxxx>
> Cc: tony.luck@xxxxxxxxx, bp@xxxxxxxxx, joe@xxxxxxxxxxx,
>  naveen.n.rao@xxxxxxxxxxxxxxxxxx, arozansk@xxxxxxxxxx,
>  linux-acpi@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Thomas
>  Winischhofer <thomas@xxxxxxxxxxxxxxxx>, Jean-Christophe Plagniol-Villard
>  <plagnioj@xxxxxxxxxxxx>, Tomi Valkeinen <tomi.valkeinen@xxxxxx>
> Subject: Re: [PATCH v2 3/9] bitops: Introduce a more generic BITMASK macro
> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.19; x86_64-redhat-linux-gnu)
> 
> Em Wed, 16 Oct 2013 10:56:00 -0400
> "Chen, Gong" <gong.chen@xxxxxxxxxxxxxxx> escreveu:
> 
> > GENMASK is used to create a contiguous bitmask([hi:lo]). It is
> > implemented twice in current kernel. One is in EDAC driver, the other
> > is in SiS/XGI FB driver. Move it to a more generic place for other
> > usage.
> > 
> > Signed-off-by: Chen, Gong <gong.chen@xxxxxxxxxxxxxxx>
> > Cc: Borislav Petkov <bp@xxxxxxxxx>
> > Cc: Thomas Winischhofer <thomas@xxxxxxxxxxxxxxxx>
> > Cc: Jean-Christophe Plagniol-Villard <plagnioj@xxxxxxxxxxxx>
> > Cc: Tomi Valkeinen <tomi.valkeinen@xxxxxx>
> 
> Acked-by: Mauro Carvalho Chehab <m.chehab@xxxxxxxxxxx>
> 
> Btw, there's another incarnation of it at sb_edac.c (GET_BITFIELD).
> It could make sense to also replace it by the newly bitops.h macro.
> 
> Regards,
> Mauro

Aha, I will update it in the next version.

Attachment: signature.asc
Description: Digital signature