Re: [PATCH 3/4] ARM: pinctrl: Add Broadcom Capri pinctrl driver

[Christian Daudt]

On Thu, Oct 17, 2013 at 7:54 AM, Stephen Warren <swarren@xxxxxxxxxxxxx> wrote:
> On 10/17/2013 12:03 AM, Christian Daudt wrote:
>> On Thu, Oct 3, 2013 at 5:23 PM, Sherman Yin <syin@xxxxxxxxxxxx> wrote:
>>> Adds pinctrl driver for Broadcom Capri (BCM281xx) SoCs.
>>>
>>> Signed-off-by: Sherman Yin <syin@xxxxxxxxxxxx>
>>> Reviewed-by: Christian Daudt <bcm@xxxxxxxxxxxxx>
>>> Reviewed-by: Matt Porter <matt.porter@xxxxxxxxxx>
>>> ---
>>>  arch/arm/mach-bcm/Kconfig       |    2 +
>>>  drivers/pinctrl/Kconfig         |   10 +
>>>  drivers/pinctrl/Makefile        |    1 +
>>>  drivers/pinctrl/pinctrl-capri.c | 1727 +++++++++++++++++++++++++++++++++++++++
>>>  4 files changed, 1740 insertions(+)
>>>  create mode 100644 drivers/pinctrl/pinctrl-capri.c
>>>
>>> diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
>>> index 69d67f7..2546365 100644
>>> --- a/arch/arm/mach-bcm/Kconfig
>>> +++ b/arch/arm/mach-bcm/Kconfig
>>> @@ -10,6 +10,8 @@ config ARCH_BCM
>>>         select GENERIC_CLOCKEVENTS
>>>         select GENERIC_TIME
>>>         select GPIO_BCM
>>> +       select PINCTRL
>>> +       select PINCTRL_CAPRI
>>>         select SPARSE_IRQ
>>>         select TICK_ONESHOT
>>>         select CACHE_L2X0
>>
>> On your subsequent patchset pls move this from Kconfig to
>> arm/configs/bcm_defconfig, and break that modification into a separate
>> patch from the drivers/* modification.
>
> The other SoCs I'm familiar with all select this from their ARCH_xxx
> config symbol.
>
I had a discussion on what is best left under ARCH and what is best
left to defconfig with Kevin Hilman a while back and the conclusion
was that any config not strictly required for bootup is best left to
defconfig. This will allow multiplatform kernels to switch to using
them as loadable modules later on, something not possible with configs
put under ARCH_xxx.

 Thanks,
    csd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/