Re: [PATCH 0/2] (Was: perf_event_mmap(vma) && !vma->vm_mm)

[Peter Zijlstra]

On Thu, Oct 17, 2013 at 05:20:27PM +0200, Oleg Nesterov wrote:
> On 10/16, Peter Zijlstra wrote:
> >
> > On Wed, Oct 16, 2013 at 10:58:00PM +0200, Oleg Nesterov wrote:
> > > OK. I'll wait for your review on this series, then send the next patch.
> > >
> >
> > Those two patches look good; thanks.
> 
> Thanks, can I have your acks for Ingo ?

Oh, I queued them :-)

> Yes, this is almost what I meant, but:
> 
> 	- name is "const char *", we need another variable

I cased that away ;-)

> 	- we do not really need "len", we can simply do
> 
> 		size = strlen(name) + 1;
> 		while (size % sizeof(u64))
> 			name[size++] = '\0';
> 
> 	  although I won't argue if you dislike "size & 7" in while().

Cute..

> 	- we can factor out strncpy(tmp, name).
> 
> Could you look at 3/2 I'll send in a minute?

I'll got have a look :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/