Re: [PATCH v4 03/15] clk: tegra: common periph_clk_enb_refcnt and clks

[Andrew Bresticker]

Hi Peter,

>  static void __init tegra30_clock_init(struct device_node *np)
>  {
>         struct device_node *node;
> -       int i;
>
>         clk_base = of_iomap(np, 0);
>         if (!clk_base) {
> @@ -1916,8 +1910,11 @@ static void __init tegra30_clock_init(struct device_node *np)
>                 BUG();
>         }
>
> -       if (tegra_clk_set_periph_banks(5) < 0)
> +       clks = tegra_clk_init(clk_max, 5);
> +       if (!clks) {
> +               WARN_ON(1);

Really minor nit: it seems strange that we WARN here for t30, but not
for t114 or t20.

Thanks,
Andrew
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/