Re: [PATCH 2/8] ACPI, CPER: Update cper info

[Naveen N. Rao]

Gong,
This mail seems to have missed copying you given the header issues.

Thanks,
Naveen

On 10/17/2013 05:51 PM, Naveen N. Rao wrote:
> On 10/16/2013 07:09 AM, Chen Gong wrote:
> > On Tue, Oct 15, 2013 at 11:47:23PM +0530, Naveen N. Rao wrote:
> > > Date: Tue, 15 Oct 2013 23:47:23 +0530
> > > From: "Naveen N. Rao" <naveen.n.rao@xxxxxxxxxxxxxxxxxx>
> > > To: "Chen, Gong" <gong.chen@xxxxxxxxxxxxxxx>
> > > Cc: tony.luck@xxxxxxxxx, bp@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx,
> > >   linux-acpi@xxxxxxxxxxxxxxx
> > > Subject: Re: [PATCH 2/8] ACPI, CPER: Update cper info
> > > User-Agent: Mutt/1.5.21 (2010-09-15)
> > >
> > > On 2013/10/11 02:32AM, Chen Gong wrote:
> > > > To satisfy the necessary of following patches and make related
> > > > definition
> > > > more clear, update some definitions about CPER. No functional changes.
> > > >
> > > > Signed-off-by: Chen, Gong <gong.chen@xxxxxxxxxxxxxxx>
> > > > ---
> > > >   drivers/acpi/apei/apei-internal.h | 12 ++++-----
> > > >   drivers/acpi/apei/cper.c          | 46
> > > > ++++++++++++++++-----------------
> > > >   drivers/acpi/apei/ghes.c          | 54
> > > > +++++++++++++++++++--------------------
> > > >   include/acpi/actbl1.h             | 14 +++++-----
> > > >   include/acpi/ghes.h               |  2 +-
> > > >   5 files changed, 64 insertions(+), 64 deletions(-)
> > > >
> > > > diff --git a/drivers/acpi/apei/apei-internal.h
> > > > b/drivers/acpi/apei/apei-internal.h
> > > > index f220d64..21ba34a 100644
> > > > --- a/drivers/acpi/apei/apei-internal.h
> > > > +++ b/drivers/acpi/apei/apei-internal.h
> > > > @@ -122,11 +122,11 @@ struct dentry;
> > > >   struct dentry *apei_get_debugfs_dir(void);
> > > >
> > > >   #define apei_estatus_for_each_section(estatus, section)            \
> > > > -    for (section = (struct acpi_hest_generic_data *)(estatus +
> > > > 1);    \
> > > > +    for (section = (struct acpi_generic_data *)(estatus + 1);    \
> > >
> > > This is a good one to rename, though I wonder if acpi_generic_error_data
> > > is more appropriate?
> > >
> > > >            (void *)section - (void *)estatus <
> > > > estatus->data_length;    \
> > > >            section = (void *)(section+1) + section->error_data_length)
> > > >
> > > > -static inline u32 apei_estatus_len(struct acpi_hest_generic_status
> > > > *estatus)
> > > > +static inline u32 cper_estatus_len(struct acpi_generic_status
> > > > *estatus)
> > >
> > > Not sure I understand the rationale for these changes - we are still
> > > dealing with ACPI/APEI generic error status/data structures. So, why
> > > the cper_ prefix?
> >
> > Because CPER is not APEI specific, beside APEI, some others like eMCA
> > needs this.
>
> Right, but even the document you point to refers to these structures as
> what they are: ACPI Generic error status/data. Clearly, CPER is an
> incorrect prefix here since CPER/UEFI does *not* seem to have the same
> structure format.
>
>
> Regards,
> Naveen

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/