Re: [PATCH v5 10/15] clk: tegra: move audio clk to common file

[Andrew Bresticker]

Hi Peter,

> +#define PLL_BASE_LOCK BIT(27)
> +#define PLL_MISC_LOCK_ENABLE 18

It doesn't look like these are used anywhere.

> +static struct tegra_sync_source_initdata sync_source_clks[] __initdata = {
> +       { .name = "spdif_in_sync", .rate = 24000000, .max_rate = 24000000, .clk_id = tegra_clk_spdif_in_sync},

It's a little weird that we have macros for audio_clks and
audio2x_clks, but not for these.

> +       /* PLLA */
> +       dt_clk = tegra_lookup_dt_id(tegra_clk_pll_a, tegra_clks);
> +       if (dt_clk) {
> +               clk = tegra_clk_register_pll("pll_a", "pll_p_out1", clk_base,
> +                               pmc_base, 0, pll_a_params, NULL);
> +               clk_register_clkdev(clk, "pll_a", NULL);

Won't tegra_register_devclks() take care of this since there's an
entry for this in t114's devclks array?

> +               *dt_clk = clk;
> +       }
> +
> +       /* PLLA_OUT0 */
> +       dt_clk = tegra_lookup_dt_id(tegra_clk_pll_a_out0, tegra_clks);
> +       if (dt_clk) {
> +               clk = tegra_clk_register_divider("pll_a_out0_div", "pll_a",
> +                               clk_base + PLLA_OUT, 0, TEGRA_DIVIDER_ROUND_UP,
> +                               8, 8, 1, NULL);
> +               clk = tegra_clk_register_pll_out("pll_a_out0", "pll_a_out0_div",
> +                               clk_base + PLLA_OUT, 1, 0, CLK_IGNORE_UNUSED |
> +                               CLK_SET_RATE_PARENT, 0, NULL);
> +               clk_register_clkdev(clk, "pll_a_out0", NULL);

Ditto.

Thanks,
Andrew
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/