Re: [PATCH v3 1/3] SDT markers listing by perf:

[Hemant Kumar]

Hi Masami,

On 10/19/2013 08:57 PM, Masami Hiramatsu wrote:
> (2013/10/18 23:44), Hemant Kumar wrote:
[...]
> > +int show_sdt_notes(const char *target)
> > +{
> > +	int ret;
> > +	LIST_HEAD(sdt_notes);
> > +
> > +	ret = get_sdt_note_list(&sdt_notes, target);
> > +	if (!list_empty(&sdt_notes)) {
> > +		if (!ret)
> Hmm, why don't you check the ret first? And I think the
> empty check should be done in display_sdt_note_info() and
> cleanup_sdt_note_list() (anyway, since both uses list_for_each*()
> it is already done).

Okay, will do that.

> > +			display_sdt_note_info(&sdt_notes);
> > +		cleanup_sdt_note_list(&sdt_notes);
> > +	}
> > +	return ret;
> > +}
> Others are good for me. :)

Great! thanks for the review. :)

--
Thanks
Hemant Kumar

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/